[syslinux:pathbased] core/com32.inc: warn about possible double use of core_xfer_buf

syslinux-bot for H. Peter Anvin hpa at zytor.com
Sun Feb 21 17:57:02 PST 2010


Commit-ID:  2ae68967b8c938c5b936cc01f38af22590a6b8fd
Gitweb:     http://syslinux.zytor.com/commit/2ae68967b8c938c5b936cc01f38af22590a6b8fd
Author:     H. Peter Anvin <hpa at zytor.com>
AuthorDate: Sun, 21 Feb 2010 17:55:57 -0800
Committer:  H. Peter Anvin <hpa at zytor.com>
CommitDate: Sun, 21 Feb 2010 17:55:57 -0800

core/com32.inc: warn about possible double use of core_xfer_buf

core_xfer_buf is still used as bounce buffer by libcom32 code linked
into the core.  This is likely unsafe -- needs to be fixed.

Signed-off-by: H. Peter Anvin <hpa at zytor.com>


---
 core/com32.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/core/com32.inc b/core/com32.inc
index d9fdc68..cb17279 100644
--- a/core/com32.inc
+++ b/core/com32.inc
@@ -117,6 +117,9 @@ not_com32r_msg	db ': not a COM32R image', CR, LF, 0
 		; Ersatz com32 invocation structure, to make libcom32
 		; code run the same if linked to the core.  This is in
 		; the .data16 segment so HighMemSize can live here.
+		;
+		; Danger, Will Robinson: it's not clear the use of
+		; core_xfer_buf is safe here.
 		global __com32
 		alignz 4
 __com32:



More information about the Syslinux-commits mailing list