[syslinux:lwip] pxe: Send tftp acks after we reach our timeout

syslinux-bot for Eric W. Biederman ebiederm at xmission.com
Fri Apr 22 20:05:54 PDT 2011


Commit-ID:  71713e663a99015cccddd2662ce97233f54fa368
Gitweb:     http://syslinux.zytor.com/commit/71713e663a99015cccddd2662ce97233f54fa368
Author:     Eric W. Biederman <ebiederm at xmission.com>
AuthorDate: Sun, 10 Apr 2011 05:14:49 -0700
Committer:  Eric W. Biederman <ebiederm at xmission.com>
CommitDate: Tue, 12 Apr 2011 14:40:54 -0700

pxe: Send tftp acks after we reach our timeout

While looking at the tftp implementation I noticed that we are not
retransmitting acks if we reach our timeout.  Not retransmitting
can be a problem when there is packet loss present in a network.

We do retransmit if the server times out but it is better if
we retransmit ourselves in case we are dealing with a stupid
tftp server that has not noticed it missed a packet from us.

Signed-off-by: Eric W. Biederman <ebiederm at xmission.com>


---
 core/fs/pxe/tftp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/core/fs/pxe/tftp.c b/core/fs/pxe/tftp.c
index 4fbe405..0f1fa56 100644
--- a/core/fs/pxe/tftp.c
+++ b/core/fs/pxe/tftp.c
@@ -141,6 +141,7 @@ static void tftp_get_packet(struct inode *inode)
 		timeout = *timeout_ptr++;
 		if (!timeout)
 		    break;
+		goto ack_again;
 	    }
             continue;
         }



More information about the Syslinux-commits mailing list