[syslinux:elflink] elflink: Delete dump_elf_module()
syslinux-bot for Matt Fleming
matt.fleming at intel.com
Tue Apr 17 11:24:10 PDT 2012
Commit-ID: b5529aac6a38f15084f7710018fd24921cb6be54
Gitweb: http://www.syslinux.org/commit/b5529aac6a38f15084f7710018fd24921cb6be54
Author: Matt Fleming <matt.fleming at intel.com>
AuthorDate: Fri, 30 Mar 2012 15:19:07 +0100
Committer: Matt Fleming <matt.fleming at intel.com>
CommitDate: Tue, 17 Apr 2012 10:58:33 +0100
elflink: Delete dump_elf_module()
dump_elf_module() doesn't have any callers (it's call site is
commented out in module_load()) and it's definition currently emits
the following build warning,
In file included from exit.c:34:0:
../include/sys/module.h: In function ‘dump_elf_module’:
../include/sys/module.h:123:55: warning: unused parameter ‘module’
Just delete it. If anyone needs a similar function in future it is
trivial to write.
Signed-off-by: Matt Fleming <matt.fleming at intel.com>
---
com32/include/sys/module.h | 17 -----------------
com32/lib/sys/module/elf_module.c | 2 --
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/com32/include/sys/module.h b/com32/include/sys/module.h
index a9ddb60..00d6331 100644
--- a/com32/include/sys/module.h
+++ b/com32/include/sys/module.h
@@ -120,23 +120,6 @@ struct elf_module {
};
-static inline void dump_elf_module(struct elf_module *module)
-{
- /*
- dprintf("module name = %s", module->name);
- printf("base_addr = 0x%p, module_size = %d\n", module->base_addr, module->module_size);
- printf("hash tlb = 0x%p, ghash tbl = 0x%p\n", module->hash_table, module->ghash_table);
- printf("str tbl = 0x%p, size = %d\n", module->str_table, module->strtable_size);
- printf("sym tbl = 0x%p, entry = %d, size = %d\n", module->sym_table, module->syment_size, module->symtable_size);
- printf("init: %p", module->init_func);
- printf("main: %p", module->main_func);
- printf("exit: %p", module->exit_func);
- printf("", module->base_addr);
- printf("", module->base_addr);
- printf("", module->base_addr);
- */
-}
-
/**
* struct module_dep - structure encapsulating a module dependency need
*
diff --git a/com32/lib/sys/module/elf_module.c b/com32/lib/sys/module/elf_module.c
index 6b4d548..b2ebbde 100644
--- a/com32/lib/sys/module/elf_module.c
+++ b/com32/lib/sys/module/elf_module.c
@@ -504,8 +504,6 @@ int module_load(struct elf_module *module) {
nr_needed = 0;
CHECKED(res, prepare_dynlinking(module), error);
//printf("check... 4\n");
- //
- //dump_elf_module(module);
/* Find modules we need to load as dependencies */
if (module->str_table) {
More information about the Syslinux-commits
mailing list