[syslinux:firmware] Makefile: Only provide one make rule for each directory

syslinux-bot for Matt Fleming matt.fleming at intel.com
Fri Nov 9 09:06:31 PST 2012


Commit-ID:  d280f9d57e4ac5739a0841eef7ca3c1cc93fd8e3
Gitweb:     http://www.syslinux.org/commit/d280f9d57e4ac5739a0841eef7ca3c1cc93fd8e3
Author:     Matt Fleming <matt.fleming at intel.com>
AuthorDate: Fri, 19 Oct 2012 16:49:05 +0100
Committer:  Matt Fleming <matt.fleming at intel.com>
CommitDate: Fri, 26 Oct 2012 16:15:15 +0100

Makefile: Only provide one make rule for each directory

Otherwise we end up with warnings like this,

   Makefile:258: warning: overriding recipe for target `efi'
   Makefile:253: warning: ignoring old recipe for target `efi'

Signed-off-by: Matt Fleming <matt.fleming at intel.com>

---
 Makefile |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index 15d0a98..a4daae5 100644
--- a/Makefile
+++ b/Makefile
@@ -247,14 +247,7 @@ all-local: $(BTARGET) $(ITARGET)
 	-ls -l $(BOBJECTS) $(IOBJECTS)
 subdirs: $(BSUBDIRS) $(ISUBDIRS)
 
-# Note the double-colon which avoids the make warning about redefining
-# a rule for libinstaller.
-$(BSUBDIRS):
-	@mkdir -p $@
-	$(MAKE) -C $@ SRC="$(SRC)/$@" OBJ="$(OBJ)/$@" \
-		-f $(SRC)/$@/Makefile $(MAKECMDGOALS)
-
-$(ISUBDIRS):
+$(sort $(ISUBDIRS) $(BSUBDIRS)):
 	@mkdir -p $@
 	$(MAKE) -C $@ SRC="$(SRC)/$@" OBJ="$(OBJ)/$@" \
 		-f $(SRC)/$@/Makefile $(MAKECMDGOALS)


More information about the Syslinux-commits mailing list