[syslinux:elflink] xfs: Remove unnecessary check in xfs_iget() function

syslinux-bot for Paulo Alcantara pcacjr at zytor.com
Tue Nov 27 12:57:09 PST 2012


Commit-ID:  4f9c17d3be09514be90f50a3b705fef92774acd4
Gitweb:     http://www.syslinux.org/commit/4f9c17d3be09514be90f50a3b705fef92774acd4
Author:     Paulo Alcantara <pcacjr at zytor.com>
AuthorDate: Sat, 14 Jul 2012 20:18:12 -0300
Committer:  Paulo Alcantara <pcacjr at zytor.com>
CommitDate: Sat, 21 Jul 2012 01:21:46 -0300

xfs: Remove unnecessary check in xfs_iget() function

xfs_iget() function is _never_ called with parent inodes with mode set
to DT_REG (regular file) and this check was used for other puporses while
doing some test cases.

Signed-off-by: Paulo Alcantara <pcacjr at zytor.com>

---
 core/fs/xfs/xfs.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/core/fs/xfs/xfs.c b/core/fs/xfs/xfs.c
index 064a6fb..85414ae 100644
--- a/core/fs/xfs/xfs.c
+++ b/core/fs/xfs/xfs.c
@@ -357,17 +357,13 @@ static struct inode *xfs_iget(const char *dname, struct inode *parent)
 	core = xfs_get_ino_core(fs, parent->ino);
     }
 
-    if (parent->mode == DT_DIR) { /* Is this inode a directory ? */
-	xfs_debug("Parent inode is a directory");
-
-	/* TODO: Handle both shortform directories and directory blocks */
-	if (core->di_format == XFS_DINODE_FMT_LOCAL) {
-	    inode = xfs_fmt_local_find_entry(dname, parent, core);
-	} else {
-	    xfs_debug("format %hhu", core->di_format);
-	    xfs_debug("TODO: format \"local\" is the only supported ATM");
-	    goto out;
-	}
+    /* TODO: Handle both shortform directories and directory blocks */
+    if (core->di_format == XFS_DINODE_FMT_LOCAL) {
+	inode = xfs_fmt_local_find_entry(dname, parent, core);
+    } else {
+	xfs_debug("format %hhu", core->di_format);
+	xfs_debug("TODO: format \"local\" is the only supported ATM");
+	goto out;
     }
 
     xfs_ino_core_free(inode, core);


More information about the Syslinux-commits mailing list