[syslinux:elflink] chainboot: Delete extraneous free() in chainboot_file()

syslinux-bot for Matt Fleming matt.fleming at intel.com
Tue Nov 27 14:15:03 PST 2012


Commit-ID:  39acf04ff0eda2e86b53187bee31c6c67e058491
Gitweb:     http://www.syslinux.org/commit/39acf04ff0eda2e86b53187bee31c6c67e058491
Author:     Matt Fleming <matt.fleming at intel.com>
AuthorDate: Thu, 15 Nov 2012 21:32:18 +0000
Committer:  Matt Fleming <matt.fleming at intel.com>
CommitDate: Thu, 15 Nov 2012 21:32:18 +0000

chainboot: Delete extraneous free() in chainboot_file()

We don't need to call free(buf) if we're jumping to the 'bail' label
because 'buf' is always free'd there.

Signed-off-by: Matt Fleming <matt.fleming at intel.com>

---
 com32/elflink/ldlinux/chainboot.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/com32/elflink/ldlinux/chainboot.c b/com32/elflink/ldlinux/chainboot.c
index 4a4a2e1..ff19c53 100644
--- a/com32/elflink/ldlinux/chainboot.c
+++ b/com32/elflink/ldlinux/chainboot.c
@@ -54,10 +54,8 @@ void chainboot_file(const char *file, uint32_t type)
 	goto bail;
     
     rv = open_file(file, &fd);
-    if (rv == -1) {
-	free(buf);
+    if (rv == -1)
 	goto bail;
-    }
     
     reg.eax.l = max;
     reg.ebx.l = 0;


More information about the Syslinux-commits mailing list