[syslinux:firmware] efi: don' t compare integers of different signs

syslinux-bot for Matt Fleming matt.fleming at intel.com
Thu Jun 20 06:51:23 PDT 2013


Commit-ID:  1be2c0ad141a7b9b094f9021fb326886b5c1c510
Gitweb:     http://www.syslinux.org/commit/1be2c0ad141a7b9b094f9021fb326886b5c1c510
Author:     Matt Fleming <matt.fleming at intel.com>
AuthorDate: Wed, 19 Jun 2013 16:46:16 +0100
Committer:  Matt Fleming <matt.fleming at intel.com>
CommitDate: Wed, 19 Jun 2013 17:11:29 +0100

efi: don't compare integers of different signs

Appease gcc and fix the following warning,

efi/console.c: In function ‘setup_gop’:
efi/console.c:81:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Matt Fleming <matt.fleming at intel.com>

---
 efi/console.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/efi/console.c b/efi/console.c
index a2585c5..3da1789 100644
--- a/efi/console.c
+++ b/efi/console.c
@@ -50,11 +50,11 @@ static int setup_gop(struct screen_info *si)
 	EFI_GRAPHICS_PIXEL_FORMAT pixel_fmt;
 	EFI_PIXEL_BITMASK pixel_info;
 	uint32_t pixel_scanline;
-	UINTN nr_handles;
+	UINTN i, nr_handles;
 	UINTN size;
 	uint16_t lfb_width, lfb_height;
 	uint32_t lfb_base, lfb_size;
-	int i, err = 0;
+	int err = 0;
 	void **gop_handle = NULL;
 
 	size = 0;
@@ -213,8 +213,8 @@ static int setup_uga(struct screen_info *si)
 	UINT32 width, height;
 	EFI_STATUS status;
 	EFI_HANDLE *handles;
-	UINTN nr_handles;
-	int i, rv = 0;
+	UINTN i, nr_handles;
+	int rv = 0;
 
 	status = LibLocateHandle(ByProtocol, &UgaProtocol,
 				 NULL, &nr_handles, &handles);


More information about the Syslinux-commits mailing list