[syslinux:firmware] efi: return a value from sem_down()

syslinux-bot for Matt Fleming matt.fleming at intel.com
Thu Jun 20 06:51:30 PDT 2013

Commit-ID:  28efc357c97933160476b551f1376b30befadabc
Gitweb:     http://www.syslinux.org/commit/28efc357c97933160476b551f1376b30befadabc
Author:     Matt Fleming <matt.fleming at intel.com>
AuthorDate: Thu, 20 Jun 2013 14:30:12 +0100
Committer:  Matt Fleming <matt.fleming at intel.com>
CommitDate: Thu, 20 Jun 2013 14:32:26 +0100

efi: return a value from sem_down()

GCC is rightly complaining that we aren't returning a value from
sem_down() like we should be,

efi/main.c: In function ‘sem_down’:
efi/main.c:174:1: warning: control reaches end of non-void function [-Wreturn-type]

It doesn't really matter what value we return because the return value
is only used in core/thread which EFI doesn't need.

Signed-off-by: Matt Fleming <matt.fleming at intel.com>

 efi/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/efi/main.c b/efi/main.c
index 5d71b39..727cfae 100644
--- a/efi/main.c
+++ b/efi/main.c
@@ -172,6 +172,7 @@ struct semaphore;
 mstime_t sem_down(struct semaphore *sem, mstime_t time)
 	/* EFI is single threaded */
+	return 0;
 void sem_up(struct semaphore *sem)

More information about the Syslinux-commits mailing list